gh-131666: mark anext_awaitable.close as a METH_NOARGS instead of METH_VARARGS
#131671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
approved these changes
Mar 25, 2025
graingert
reviewed
Mar 25, 2025
| return self | ||
|
|
||
| anext_awaitable = anext(A(), "a").__await__() | ||
| self.assertRaises(TypeError, anext_awaitable.close, 1) |
There was a problem hiding this comment.
this results in an unawaited coroutine warning
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 1, 2025
…ead of `METH_VARARGS` (python#131671)
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…ead of `METH_VARARGS` (python#131671)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really an issue because the underlying coroutine wrapper will raise a TypeError, so there won't be a different exception raised now. It's just that instead of "coroutine_wrapper.close taskes no argument", we have "anext_awaitable.close takes no argument".
anextawaitable_close()should be aMETH_NOARGSnotMETH_VARARGS#131666